Return-Path: Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 42004 invoked by uid 500); 1 Jul 2003 12:51:54 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 41895 invoked from network); 1 Jul 2003 12:51:53 -0000 Received: from mta08.mail.au.uu.net (HELO mta08.mail.mel.aone.net.au) (203.2.192.89) by daedalus.apache.org with SMTP; 1 Jul 2003 12:51:53 -0000 Received: from 1Cust215.tnt13.syd2.da.uu.net ([63.60.235.215]) by mta08.mail.mel.aone.net.au with ESMTP id <20030701125151.TZKZ15355.mta08.mail.mel.aone.net.au@1Cust215.tnt13.syd2.da.uu.net> for ; Tue, 1 Jul 2003 22:51:51 +1000 From: Conor MacNeill To: "Ant Developers List" Subject: Re: New Laucher Date: Tue, 1 Jul 2003 23:00:37 +1000 User-Agent: KMail/1.5 References: <200306272140.24470.conor@cortexebusiness.com.au> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200307012300.37998.conor@cortexebusiness.com.au> X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Tue, 1 Jul 2003 10:02 pm, Stefan Bodewig wrote: > On Fri, 27 Jun 2003, Conor MacNeill > > wrote: > > Thoughts? > > The only thing I've stumbled over for now is the almost duplicate code > of Locator#getClassLocationURL and > oata.util.LoaderUtils#getClassSource - I'd like to see them merged in > some way. > I wanted to keep the dependencies between Ant proper and the launcher to a minimum. To have the code available to the launcher, the only choice would be to move the code into the launcher.Locator and make use of it from there. I don't think the current code would be good candidate for that due to its coupling to FileUtils. The alternative candidate code (commented out) would be OK, although I'm a bit leery of the url.openConnection(). What do you think? Conor --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org