Return-Path: Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 26571 invoked by uid 500); 15 Jul 2003 13:32:07 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 26517 invoked from network); 15 Jul 2003 13:32:06 -0000 Received: from unknown (HELO mx1.try.sybase.com) (130.214.10.19) by daedalus.apache.org with SMTP; 15 Jul 2003 13:32:06 -0000 Received: from mail.try.sybase.com (mail.try.sybase.com [130.214.10.18]) by mx1.try.sybase.com (8.11.6/8.11.0) with ESMTP id h6FCMQB04981 for ; Tue, 15 Jul 2003 06:22:26 -0600 Received: from vpnlinux ([10.22.120.59]) by mail.try.sybase.com (8.11.6/8.11.6) with SMTP id h6FDOGm01934 for ; Tue, 15 Jul 2003 07:24:16 -0600 Reply-To: From: "Adam Jack" To: "'Ant Developers List'" Subject: RE: FW: ConcurrentModificationException Date: Tue, 15 Jul 2003 07:32:05 -0600 Message-ID: <003f01c34ad5$7e447150$3b78160a@sybase.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook CWS, Build 9.0.2416 (9.0.2910.0) X-MIMEOLE: Produced By Microsoft MimeOLE V5.50.4910.0300 In-Reply-To: <1058259266.28864.4002.camel@preilly.local.corvil.com> Importance: Normal X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N I see you've checked in the iterator -> int fix, thank you both. Peter wrote: "revert the script test that showed up the problem in the first place". Sorry, but what does this mean to the non-antdev-initiated? I am using Krysalis Centipede, which is clearly too big to have as a unit test for ant, but which does gump off nightly ant, and will test this feature. You can (at the least) count on us to report any failures we get to the ant list. :-) Do you need us to attempt to create a unit test for ant, or is this enough? Again, thanks for your quick work and support with this fix. regards Adam -----Original Message----- From: peter reilly [mailto:peter.reilly@corvil.com] Sent: Tuesday, July 15, 2003 2:54 AM To: Ant Developers List Subject: Re: FW: ConcurrentModificationException Yep, the import task works again. We probably should revert the script test that showed up the problem in the first place. Peter On Tue, 2003-07-15 at 09:35, Stefan Bodewig wrote: > With a loop like > > for (int i = 0; i < children.size(); i++) { > Object o = children.get(i); > > instead of > > Iterator it = children.iterator(); > while (it.hasNext()) { > Object o = it.next(); > > we should be on the save side, I think. children can only grow as > there are only methods to add, not to remove tasks/types. > > Stefan > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org > For additional commands, e-mail: dev-help@ant.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org