ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: cvs commit: ant/src/testcases/org/apache/tools/ant DirectoryScannerTest.java
Date Tue, 22 Jul 2003 12:08:21 GMT
On 21 Jul 2003, Stefan Bodewig <bodewig@apache.org> wrote:

> Your getCanonicalPath fix will not catch the situation for any OS
> other than Windows (the way it is coded right now).

I don't have a solution apart from "do it for all OSes" and "do it for
none".

> It will also slow down scanning considerably, probably to the point
> that your prior optimization gets undone.

OK, as it is only performed for the new "roots" created from the
include patterns, this is less significant than I first thought.  It
will become an issue for a long list of includes - the thing that has
triggered your optimization in the first place.

> And it would probably break in the presence of symbolic links if we
> applied it to OSes that support them.

I still think this is true.

Maybe using something like findFileCaseInsensitive instead of
getCanonicalPath would be better.  If we agree that we need to return
the exact case on case insensitive filesystems, that is.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message