ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: cvs commit: ant/src/main/org/apache/tools/ant/types Resource.java ZipScanner.java
Date Tue, 29 Jul 2003 09:34:21 GMT
On 29 Jul 2003, <bodewig@apache.org> wrote:

>   Some tasks rely on the DFS ordering getIncludedXYZ used to provide

I'm not sure whether we want to provide this as the sort order has
never been documented.

The recent changes in DirectoryScanner could lead to a situation in
which A/C will be returned before A/B, I don't think this is a big
issue but patched it for completeness.

The change to ZipScanner in turn is necessary as
getIncludedDirectories could return A/B before returning A itself -
this could cause trouble within Zip where the code assumes that the
parents of a given directory have been added before the directory
itself[1].

The change to Resource is merely cosmetic.

Stefan

Footnotes: 

[1] Not strictly true, the code will ensure that the parents have been
added before, but may do the wrong thing WRT to Unix permissions once
my next patch to Zip is committed.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message