ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steve Loughran <stev...@iseran.com>
Subject Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Java.java
Date Mon, 28 Jul 2003 20:01:08 GMT
antoine@apache.org wrote:

> antoine     2003/07/28 10:59:28
> 
>   Modified:    src/main/org/apache/tools/ant/taskdefs Java.java
>   Log:
>   style
>   
>   Revision  Changes    Path
>   1.66      +97 -0     ant/src/main/org/apache/tools/ant/taskdefs/Java.java
>   
>   Index: Java.java

oh, that reminds me:

Can I take out an optimistic lock on CommandLineJava and 
commandline.java for the next few days.

I've been adding the <assertion> facility, but have ended up doing more 
refactoring than planned, on account of I am eliminating all the 
String[] array stuff and working with lists right up until the end. 
String[] may appear higher performance, but with the size() operators 
all triggering evaluation and each subcomponent calling size() before 
creating the subsidiary String[] array, we are doing about 4x the amount 
of work we need. adding command to a list is a lot easier...

Anyhows, I will check everything with with checkstyle cleanup once it is 
  running through all the tests and regressing against my own apps.

-steve






---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message