ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christopher Lenz <cml...@gmx.de>
Subject Re: [OT] FindBugs
Date Thu, 24 Jul 2003 13:02:05 GMT
Stefan Bodewig wrote:
> Hi,
> 
> I just stumbled over findbugs[1] (via Cafe au lait) and ran it over
> Ant's sources.
> 
> Some of the reported problems are non-issues, but it also detected
> some things that checkstyle doesn't[2].  Some examples:
> 
> * BaseFilterReader line 88 should use "" instead of new String().
> 
> * bufferPos in TailFilter is never used
> 
> * line 897 in IntrospectionHelper should use Boolean.valueOf instead
>   of the constructor.

You can check for 1/ and 2/ with Checkstyle, too:

<module name="IllegalInstantiation">
   <property name="classes"
             value="java.lang.Boolean,java.lang.String"/>
</module>

See:
http://checkstyle.sourceforge.net/config_coding.html#IllegalInstantiation

-chris



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message