ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 18154] - SimpleP4OutputHandler can throw exceptions that should be build exceptions
Date Wed, 30 Jul 2003 15:22:15 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18154>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18154

SimpleP4OutputHandler can throw exceptions that should be build exceptions





------- Additional Comments From matt@thebishops.org  2003-07-30 15:22 -------
You have a good point, I forgot there's no build listener that kills a build by default when
a task 
logs an error.

The problem with SimpleP4OutputHandler throwing an exception is that many P4 errors are 
multiline, so if we throw on the detection of the first line of an error, the rest of the
message from 
P4 is lost.  It might be better for the handler to set an error state on P4Base (along with
a 
message), so that when the execCommand finishes, it can throw the entire message in a 
BuildException from P4Base.

I can give this a try if the idea has merit.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message