ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 19897] - Patch to implement the namespaced antlib + other changes
Date Wed, 23 Jul 2003 17:06:46 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19897>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19897

Patch to implement the namespaced antlib + other changes





------- Additional Comments From peter.reilly@corvil.com  2003-07-23 17:06 -------
>IIUC <rundef> would be nothing more than a convenience layer, it saves
>setting the adaptto and adapter attributes, right?

True for rundef, but a definer may be more complicated than that.
For example it may use reflection to get classes from a jar and
add them to ant as types.

> A minor nit - I'd give antlib a manual page of its own 8-)
+1, later

> Then we still have the Antlib implements TaskContainer thing.
Another reason to use taskcontainer is to allow antlib's to
have start-up scripts - for checking the env for example.

>Finally, I don't like the way Antlib couples itself to ProjectHelper2.
>ProjectHelper2 is getting more equal than other "ProjectHelper"
>implementations with that - OK, it already is, but this makes the point even
>stronger.  Maybe there is a way to extract the functionality that Antlib needs
>from ProjectHelper2 and use it from both classes?
True, (very true). This needs some thought. For example the current
ProjectHelperImpl is a little out of date (it is useful to have
ProjectHelper2 and ProjectHelperImpl ?)

>I think all those points can easily be dealt with in CVS.  No objections >against
>committing the patch from my side.

Excellent, however I have one problem.. My use-case for
using a taskcontainer was to allow the definitions to
be used in the same antlib file. There is a problem
with this when namespace prefixes are implemented.
The new definitions will belong to the namespace uri associated
with the antlib file/resource. To use them in the same
file will involve a little messing with uri handling in the
antlib task/ComponentHelper.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message