ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 21481] New: - CvsTagDiff.java: rdiff command string adds single quote in wrong place
Date Thu, 10 Jul 2003 22:59:52 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21481>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21481

CvsTagDiff.java: rdiff command string adds single quote in wrong place

           Summary: CvsTagDiff.java: rdiff command string adds single quote
                    in wrong place
           Product: Ant
           Version: 1.6Alpha (nightly)
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: Blocker
          Priority: Other
         Component: Core tasks
        AssignedTo: dev@ant.apache.org
        ReportedBy: pkordel@hotmail.com


when running cvstagdiff and passing in starttag and endtag, but no dates, the 
command string passed to rdiff adds a single quote after each tag, resulting 
in the initial -r switch falling off.

Index: CvsTagDiff.java
===================================================================
RCS 
file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/cvslib/CvsTagD
iff.java,v
retrieving revision 1.14
diff -u -r1.14 CvsTagDiff.java
--- CvsTagDiff.java	15 Jun 2003 20:26:57 -0000	1.14
+++ CvsTagDiff.java	10 Jul 2003 22:41:30 -0000
@@ -213,13 +213,12 @@
     public void execute() throws BuildException {
         // validate the input parameters
         validate();
-
         // build the rdiff command
         String rdiff = "rdiff -s " +
-            (m_startTag != null ? ("-r " + m_startTag) : ("-D '" + 
m_startDate))
-            + "' "
-            + (m_endTag != null ? ("-r " + m_endTag) : ("-D '" + m_endDate))
-            + "' " + m_package;
+            (m_startTag != null ? ("-r " + m_startTag) : ("-D '" + 
m_startDate + "' "))
+            + " "
+            + (m_endTag != null ? ("-r " + m_endTag) : ("-D '" + m_endDate 
+ "' "))
+            + " " + m_package;
         log("Cvs command is " + rdiff, Project.MSG_VERBOSE);
         setCommand(rdiff);

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message