ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Conor MacNeill <co...@cortexebusiness.com.au>
Subject Re: New Laucher
Date Tue, 08 Jul 2003 12:11:50 GMT
On Thu, 3 Jul 2003 11:16 pm, Stefan Bodewig wrote:
>
> It's JDK 1.1 legacy as far as I'm concerned and could those be swapped
> against the commented Axis' code.
>

It turns out this "legacy" code works better than the commented out code 
because it handles spaces in file names (which are otherwise rendered as %20)

So, I can move the code into Locator but I also need to move 
FileUtils.fromURI() which is not too much of a problem, except for its use of 
Os.isFamily("dos") and FileUtils.normalize().

The first, I intend to replace with (File.pathSeparatorChar == ';'). That 
should be equivalent except on Netware but I'm not sure if Netware should be 
excluded or not - i.e. is the original code based on "dos" correct?

The second linkage, the normalize call, I will just remove.

So overall actions are

1. Move getClassSource and getResourceSource to Locator from LoaderUtils. 
2. Move bulk of fromURI from FileUtils to Locator.fromURI
3. Recode FileUtils.fromURI to use Locator.fromURI with the additional 
normalize step

Since all the methods are 1.6 methods there are no backward compat issues.

The issues could be
1. getClassSource and getReosurceSource results will not be normalized. I 
don't think that is a great issue
2. Netware operation?

Thoughts
Conor




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message