ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 13323] - Property files loose formating when use propertyfile task
Date Tue, 08 Jul 2003 15:46:22 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13323>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13323

Property files loose formating when use propertyfile task





------- Additional Comments From gus.heck@olin.edu  2003-07-08 15:46 -------
I'd like to see this added, and here's why..

Since you have written a customized property file writing mechanism I was
looking at it to see if it solves one of my problems. I think if an option to
not write the date comment could be provided it would help my application. I
wind up with a whole bunch of spurious cvs commits in an automated mechanism
that I wrote for recording symlinks on my website with my <symlink> task. The
problem is due to dates changing in otherwise identical property files. While
Ideally, I should simply not write the file if there are no changes, but that
takes some work of checking for an existing file, loading it and comparing the
results. I think my task will probably run faster if I just write the file as I
am doing and this could be a simpler fix to my problem.

So if you can find a way to throw in a nodate option, I will probably rework my
<symlink> code to take advantage of it... 

On the level of details I notice that yor code will probably need some changes
before the committers accept it. Ant uses these code conventions

http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html

quick issues I saw included lines over 80, single line ifs that don't have {} and 

 if ( propLine == null )
        {

instead of

 if ( propLine == null ) {

Also I noticed some funny randomish spacing around some asignments.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message