ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peter reilly <peter.rei...@corvil.com>
Subject Re: Checkstyle Audit
Date Thu, 03 Jul 2003 15:15:16 GMT
Excellent work.
I have a problem with three rules:

   major: The "DesignForExtensionCheck" seems a bit silly.
   minor: The "LeftCurlyCheck" is against my in-house rule that
          if there is a multi line condition, the { should be
          on a separate line - but I can live the rule.
   minor: "RedundantThrowsCheck: It complains about BuildException.

Peter

On Thu, 2003-07-03 at 15:26, Conor MacNeill wrote:
> I've done a checkstyle audit with the new xdoc generating stylesheets and 
> uploaded this to the server
> 
> http://ant.apache.org/reports/checkstyle/
> 
> It's not linked into the rest of the site (nor is it in CVS). It's mainly just 
> for interest at the moment. It does show which files are good candidates for 
> some cleanup action :-).
> 
> BTW, this is checkstyle on maximum volume. I'll probably turn it down a bit a 
> little later on. It is too late to fix some of our code now, for backward 
> compatibility reasons, so I'll be trying to focus on what can be fixed.
> 
> If you hover over a line in the detail report it will show which checkstyle 
> module triggered the report.
> 
> Conor
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message