ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs TypeAdapterTest.java
Date Thu, 26 Jun 2003 14:03:12 GMT
On 26 Jun 2003, <peterreilly@apache.org> wrote:

>      * unifies the type and task definitions into one table

the only problem with this I see is that we are causing a potential
backwards incompatibility with Project.getTaskDefinitions now
returning an empty table - I don't think this is correct (remember you
had to alter the test to pass because of this).

<antstructure> uses it for example and creates a now empty entity for
Ant:

<!ENTITY % tasks "">

doesn't look too interesting.

Maybe we should record all tasks added via addTaskDefinition in a
separate table and return a "subtable" of the definitions that only
contained the defined tasks here?

>      * <typedef/> has a number of new attributes:
>          - adapter
>          - adaptto
>          - onerror

onerror is used for loading of the equivalent of defaults.properties
in the future, I guess.  Do we really want to expose it as a general
attribute?

Apart from that I've only seen some style violations checkstyle's
going to pick up on my first skimming through the changes.  The next
nightly Gump run will be interesting.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message