ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs TypeAdapterTest.java
Date Fri, 27 Jun 2003 09:38:48 GMT
On 26 Jun 2003, peter reilly <peter.reilly@corvil.com> wrote:

> The problem is that as tasks are now types, the getTypeDefinitions()
> should now return everything.

Yes, I'm aware of this.  But there may be custom tasks - other than
<antstructure/> - that rely on the old separation of things.

> If this is a problem, I could make a new method
> Project#getAllTypes() that would return the complete set of types,
> and rework Project#getTaskDefinitions to iterate through the table
> and only show the types that are tasks, and
> Project#getTypeDefinitions to do the same for types that are not
> tasks.

Sounds like the best solution to me (and it looks as if you had
already done it 8-).

> Alternatively, <antstructure/> could be reworked to do the same,
> or simply drop the tasks ENTITY.

<antstructure> is only one example, there may be a whole lot more.

> On Thu, 2003-06-26 at 15:03, Stefan Bodewig wrote:
>> On 26 Jun 2003, <peterreilly@apache.org> wrote:

>> >          - onerror
>> 
>> onerror is used for loading of the equivalent of
>> defaults.properties in the future, I guess.  Do we really want to
>> expose it as a general attribute?
> 
> The reason for this to be visible is to allow optional types/tasks
> to be defined by thirdparty libraries - for example ant-contrib or
> antelope.

OK, I agree with this use-case.

> Perhaps an "optional" attribute could be used instead.

Yes, that seems to capture the intent a bit better.

>> The next nightly Gump run will be interesting.
> 
> Heres hoping it is uninteresting....

Even if the outcome is boring (no problem have been introduced - and
it looks pretty good so far), it still is interesting 8-)

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message