ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan.Mate...@rzf.fin-nrw.de
Subject AW: Selector Test
Date Thu, 05 Jun 2003 07:47:33 GMT
> +1 for providing a way to translate to filenames. I'm sure 
> that will be 
> much easier to use when debugging a test failure. This should 
> be easier to 
> call from the test, though. Perhaps a new method in 
> BaseSelectorTest that 
> takes a selector and the selection string and calls 
> assertEquals() the way 
> you describe. If you could submit a patch against 
> BaseSelectorTest for 
> this, I'd be glad to apply it. 

Ok, I will do that.
Nice idea with that method.

> If you could change the README 
> while you 
> were at it to describe how to use it, even better.

Of course - updated doco.
Maybe you can take a look at 
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20474

In the attachement
(http://nagoya.apache.org/bugzilla/showattachment.cgi?attach_id=6622)
I have updated the doco "<manual>/selector.html" and
"<manual>/selector-programming.html".
Two more eyes (or more) on that would be good (especially I´m not a native
speaker/writer).


> Regarding setting properties on the build that creates the test 
> environment, I'm not sure I understand the necessity. Unit 
> tests are quite 
> static by design, to ensure consistent results. The more 
> complexity you 
> add, the more likely a test can fail in a way unrelated to 
> the units the 
> tests are testing. What makes you want to use passed-in properties?

I have to ensure that the xml-file is always conform to the test classes. If
I pass
the values from test class to xml-file, the only place to update is the test
class.
And because its a compiled class, it seems to be very static...

So I have no redundance.

OK, I´m lazy :-)

> Even if it is desirable to allow property settings to affect 
> testcases, 
> wouldn't it be better to add a setProperty() call in 
> oata.BuildFileTest 
> rather than creating a properties file? Something that called 
> project.setUserProperty()?

I create a property file because the tasks in the xml-file should
get these values. I don´t think that they will get the properties
from BuildFileTest. But I´m not sure in this point.



First I will put the "name-translation" to the BaseSelectorTest. Then I
spent a little bit
time on the property question. Maybe I found that the properties of
BaseFileTest are available
to the xml-file...


Jan

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message