Return-Path: <bodewig@apache.org>
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 30269 invoked from network); 23 May 2003 06:14:21 -0000
Received: from bodewig.bost.de (195.227.98.11)
  by daedalus.apache.org with SMTP; 23 May 2003 06:14:21 -0000
Received: (from bodewig@localhost)
	by bodewig.bost.de (8.11.6/8.11.6) id h4N6EWt19139;
	Fri, 23 May 2003 08:14:32 +0200
X-Authentication-Warning: bodewig.bost.de: bodewig set sender to
 bodewig@apache.org using -f
To: dev@ant.apache.org
Subject: Re: Enhance chgrp/chown?
References: <20030519121810.21048.qmail@icarus.apache.org>
	<3ECA485B.10908@cognition.olin.edu> <m3ptmc4w7m.fsf@bodewig.bost.de>
	<3ECBEA47.4020106@cognition.olin.edu> <m3y90zmslx.fsf@bodewig.bost.de>
	<3ECD449A.6010905@cognition.olin.edu>
From: Stefan Bodewig <bodewig@apache.org>
Date: 23 May 2003 08:14:32 +0200
In-Reply-To: <3ECD449A.6010905@cognition.olin.edu>
Message-ID: <m3brxui3zr.fsf@bodewig.bost.de>
Lines: 65
User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Portable Code)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

On Thu, 22 May 2003, Gus Heck <gus-antdev@cognition.olin.edu> wrote:
> Stefan Bodewig wrote:
>> On Wed, 21 May 2003, Gus Heck <gus-antdev@cognition.olin.edu>
>> wrote:

>>>Another logicical addition to all 3 of them might be allowing
>>>dirsets.
>> I think the type="dir" attribute covers this, doesn't it?
> 
> I guess multiple ways of doing things just isn't popular with anyone
> around here.

Uhm, Perl used to be my favorite scripting language for quite some
time.  But probably not because of TIMTOWTDI 8-)

If there is an existing way to do a thing I have no problem with
adding another way if it improves consistency accross tasks.  But
there are not that many tasks supporting <dirset> (yet?).

> Makes me wonder why we have dirsets at all if we can't use them
> here, and only in a narrow way for subant...

The main reason for <dirset> has been as a nested element in <path>.

> I suppose type="dir" is a pre-dirset feature on chmod,

Yes.

> These tasks are not yet released, so maybe they should take DirSets
> instead?

They inherit it from ExecuteOn, so they cannot un-use the attribute
(well, they could override the setter and throw an exception).

> Maybe fileset should have had a type="dir|file|both" instead of
> having Dirsets.

<fileset> always does the implict type="both" - it is the task that
decides whether it invokes getIncludedFiles or
getIncludedDirectories.  Take a look at the code of FileSet and
DirSet, they are identical.

We considered making dirsets and filesets interchangeable by having
dirset return the included directories in getIncludedFiles but decided
against it - not just because it was hackish but also because tasks
might rely on the fact that getIncludedFiles returns files and not
directories.

> What direction should I be taking with chgrp/chown here?

Thinking about it a second time - add <dirset> support to ExecuteOn.

> Given the constraints of back compatability, it seems that the only
> way to make life easy for the user is keep adding the new ways of
> referencing things (ie dirsets) to the old tasks in which they make
> sense.

True.

> ok I understand. Have you found out anything about tandem/nonstop
> and chgrp chown yet?

No, sorry.  I'll keep you posted.

Stefan