Return-Path: <jakarta-ant@ehatchersolutions.com>
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 57409 invoked from network); 28 May 2003 13:27:20 -0000
Received: from mail8.atl.registeredsite.com (64.224.219.82)
  by daedalus.apache.org with SMTP; 28 May 2003 13:27:20 -0000
Received: from netmail.mail.registeredsite.com ([216.122.69.14])
	by mail8.atl.registeredsite.com (8.12.8/8.12.6) with ESMTP id h4SDRKTw007544
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NOT)
	for <dev@ant.apache.org>; Wed, 28 May 2003 09:27:21 -0400
Received: (qmail 32430 invoked by uid 89); 28 May 2003 13:27:59 -0000
Received: from unknown (HELO ehatchersolutions.com) (128.143.103.27)
  by netmail.registeredsite.com with SMTP; 28 May 2003 13:27:59 -0000
Date: Wed, 28 May 2003 09:27:20 -0400
Subject: Re: cvs commit:
 ant/src/main/org/apache/tools/ant/taskdefs/optional/junit
 FormatterElement.java JUnitTask.java
Content-Type: text/plain; charset=US-ASCII; format=flowed
Mime-Version: 1.0 (Apple Message framework v552)
From: Erik Hatcher <jakarta-ant@ehatchersolutions.com>
To: "Ant Developers List" <dev@ant.apache.org>
Content-Transfer-Encoding: 7bit
In-Reply-To: <200305282326.37385.conor@cortexebusiness.com.au>
Message-Id: <1BFD9984-9110-11D7-B239-000393A564E6@ehatchersolutions.com>
X-Mailer: Apple Mail (2.552)
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

On Wednesday, May 28, 2003, at 09:26  AM, Conor MacNeill wrote:
> On Wed, 28 May 2003 11:12 pm, ehatcher@apache.org wrote:
>> ehatcher    2003/05/28 06:12:04
>>
>>   Modified:    .        WHATSNEW
>>                docs/manual/OptionalTasks junit.html
>>                src/main/org/apache/tools/ant/taskdefs/optional/junit
>>                         FormatterElement.java JUnitTask.java
>>   Log:
>>   Apply patch from #20270 - adds if/unless clause to junit formatters.
>> Submitted by Eli Tucker
>>
>
> Do we really want if/unless on every subelement of each task? IMHO, 
> this feels
> wrong.

Well, I only added it to one element of one task :) - but your point is 
taken.  The reason I applied this patch is that I think it really 
speeds up running JUnit tests if you don't want XML output (running 
interactively), but want XML output when running continuous integration 
builds for reporting purposes.

If folks feel strongly about it, I'll revert it.

There already is precedent in the <junit> task for this type of thing 
with the <test>/<batchtest> if/unless capability.

	Erik