ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rey Francois <Francois....@capco.com>
Subject RE: [PATCH] Fix for VAJ4
Date Fri, 02 May 2003 14:57:32 GMT
I have tried Martin's patch and all seems fine. Just one thing: line 56 of
Martin's patch is conflicting with javadoc notation:

+ *                    JSP Page Compile Generated Code/**, Visual
Age*/**</td>

Should be replaced by

+ *                    JSP Page Compile Generated Code/**, Visual
Age*&#47;**</td>

Also, I have just added an additional attachment to the bug report ()
containing a final documentation patch that contains both Martin's changes
and mine. Again this is a patch for version 1.5.3, this time made using
"diff -u".

Finally, I suggest to include in the binary release (I guess optional.jar)
the file src\main\org\apache\tools\ant\taskdefs\optional\ide\default.ini so
that people do not have to download the src release to install these tasks.

I think all is set,

Fr.

-----Original Message-----
From: Martin Landers
To: Ant Developers List
Sent: 2/05/2003 16:05
Subject: Re: [PATCH] Fix for VAJ4


Hi,

[... VAJ Mock classes ...]

> We can use them to compile the VAJ classes that we distribute with
> Ant, but I'm not sure whether we could distribute the mock classes
> themselves.

Hm, AFAIC not distributing the mock classes themselves, only task
binaries
and sources is fine. I just didn't like the idea of people having to
import the complete Ant source into VAJ and back out, just to create the
binaries for the VAJ tasks... (The same thing Francois mentions - the
old
"installation mode" is awful).

> They'll have "ibm" in their names which may be enough to
> make lawyers jump up and down.

Lawyers are a strange kind of people.
I share your concern that the mock classes might cause problems... Which
is why I didn't use the original classes or documentation in creating
the
mock classes and added the disclaimer to each one. But I can't help
about
the names having "com.ibm..." in them, so let's stick with your proposal
and not include the mock classes in the Ant distributions or publicly
available CVS tree. People who have an interest in changing the taks
(that
is need to recompile the binaries) should have VAJ around anyway...

If you feel the Bugzilla attachment may be seen as "distribution", just
remove it.

> As long as we distribute binaries, things should be fine, no?

Yep, I think so. The binaries (and sources) for the tasks only contain
references to the IBM classes, and I hope lawyers don't go crazy for an
"import com.ibm...." ;)

cu
Martin

--
{_{__}_}  Martin Landers                               landers@fs.tum.de
   oo         "elk"                                        elk@fs.tum.de
  / /
 (..)     " Who is General Failure and why is he reading my harddisk ? "
  --


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org

Mime
View raw message