ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gus Heck <gus-ant...@cognition.olin.edu>
Subject Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Chmod.java ExecuteOn.java
Date Tue, 20 May 2003 15:23:07 GMT
I noticed that this effects the chgrp and chown tasks... which also 
Extend ExcecuteOn and therefore now have the maxparallel atribute as 
well. I plan to patch the docs to reflect this and the fact that they 
seem to accept the verbose atribute as well.

Other things I have noticed is that a little while back chmod added 
support for Os.isFamily("tandem"). Should this go into chmod/chgrp too? 
If someone verifies that non-stop supports chgrp and chown in the 
standard unixy way I'll be glad to patch it as well.

Furthermore, it seems that chgrp and chown really ought to support 
esentially the same feature set as chmod, but currently chmod has a fair 
number of additional features. I might flesh out chmod and chgrp, but 
since that takes more than a few minutes work, I would like to know if 
this is desired.

Finally, it seems a bit incongruous that chmod is not in optional/unix/ 
(now that that package exists), and the situation seems ripe for a bit 
of refactoring, such that AbstractAccessTask.java holds most of the 
support for these three tasks and each task holds the specific 
differences. Of course moving a task to another package, brings up back 
compatability questions at the api level so I am hoping for a discussion 
of the severity of problems likely from moving chmod. It doesn't seem 
like the sort of class that is likely to be extended or used in other 
code, but that might just be my lack of imagination (or need for another 
coffee).

Oh and do we have any idea when the target date for the first 1.6 beta 
release is... if this is to be done, I am sure we want the maximum 
ammount of user testing and feedback on it.

-Gus

bodewig@apache.org wrote:
> bodewig     2003/05/19 05:18:10
> 
>   Modified:    .        WHATSNEW build.xml
>                docs/manual/CoreTasks apply.html chmod.html
>                src/main/org/apache/tools/ant/taskdefs Chmod.java
>                         ExecuteOn.java
>   Log:
>   You can now limit the parallelism of <apply> and <chmod> by using the
>   new maxparallel attribute.
>   Submitted by:	Frank A. Hunleth <fhunleth at cs dot wustl dot edu>
>   used in build.xml to fix PR: 17640
>   
>   With the new addsourcefile attribute, you can make <apply> ommit the
>   source file names from the command line.
>   PR: 13654
>   
>   <apply> and <chmod> now support nested <filelist>s as well.
>   PR: 15929
>   
>   <apply> and <chmod> will display a summary if you set the new verbose
>   attribute to true.
>   PR: 19883
>   
>   Revision  Changes    Path
>   1.421     +12 -0     ant/WHATSNEW
>   
>   Index: WHATSNEW
>   ===================================================================
>   RCS file: /home/cvs/ant/WHATSNEW,v
>   retrieving revision 1.420
>   retrieving revision 1.421
>   diff -u -r1.420 -r1.421
>   --- WHATSNEW	16 May 2003 09:22:28 -0000	1.420
>   +++ WHATSNEW	19 May 2003 12:18:07 -0000	1.421
>   @@ -346,6 +346,18 @@
>      that can be used to turn of Microsoft extensions while using the jvc
>      compiler.  Bugzilla Report 19826.
>    
>   +* You can now limit the parallelism of <apply> and <chmod> by using the
new
>   +  maxparallel attribute.
>   +
>   +* With the new addsourcefile attribute, you can make <apply> ommit the
>   +  source file names from the command line.  Bugzilla Report 13654.
>   +
>   +* <apply> and <chmod> now support nested <filelist>s as well.
>   +  Bugzilla Report 15929.
>   +
>   +* <apply> and <chmod> will display a summary if you set the new
>   +  verbose attribute to true.  Bugzilla Report 19883.
>   +
>    Changes from Ant 1.5.2 to Ant 1.5.3
>    ===================================
>    
>   
>   
>   
>   1.377     +3 -2      ant/build.xml
>   
>   Index: build.xml
>   ===================================================================
>   RCS file: /home/cvs/ant/build.xml,v


Mime
View raw message