ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 19897] - Patch to implement the namespaced antlib + other changes
Date Thu, 22 May 2003 08:42:27 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19897>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19897

Patch to implement the namespaced antlib + other changes





------- Additional Comments From peter.reilly@corvil.com  2003-05-22 08:42 -------
patch 6452 is the first step in decoupling the overall patch
The patch is in tar.gz format.
It adds add(Type) to the introspection rules and adds the
method to condition, filterchain, path, selector and tokenfilter.
Note that the implementation of add(Type) in IntrospectionHelper.java
will change as addConfigured(Type), polymorphic support and role support
is added to IH (and UE, RC, CH).

The tar.gz contains four files:
   * add.make - the script used to generate the patch + comments
   * add.diff - the patch file produced as a result of cvs diff -c <filelist>
   * addtype.xml -  unit test build script
   * AddTypeTest.java - unit test for addtype


* comments in  add.make *

This patch adds the add(Type) to the introspection rules and
updates ConditionBase, FilterChain, Path, SelectorBase and TokenFilter
to use the new introspection rule.

Changed Files: the diff is contains in the file
"add.diff" using cvs diff -c <changed files>

========================================= 
=   Changed Files  
========================================= 

src/main/org/apache/tools/ant/ProjectHelper.java
  add two methods used by introspection - getComponentClass and
  createComponent

src/main/org/apache/tools/ant/IntrospectionHelper.java
  implement addTypeMethods add(Type)
  
src/main/org/apache/tools/ant/filters/TokenFilter.java
   get TokenFilter to use add(Type) instead of dynamicconfigurator
   make all nested classes ProjectComponents

src/main/org/apache/tools/ant/taskdefs/Delete.java
   implement an add(FileSelector) method

src/main/org/apache/tools/ant/taskdefs/MatchingTask.java
   implement an add(FileSelector) method

src/main/org/apache/tools/ant/taskdefs/condition/ConditionBase.java
   add an add(Condition) method to demostrate use of add(Type) method

src/main/org/apache/tools/ant/types/AbstractFileSet.java
   implement add(FileSelector)

src/main/org/apache/tools/ant/types/FilterChain.java
   use add(ChainableReader) instead of DynamicConfigurator

src/main/org/apache/tools/ant/types/Path.java
  add an add(Path) method

src/main/org/apache/tools/ant/types/optional/ScriptFilter.java
  remove set/get project as parent imlements them now

src/main/org/apache/tools/ant/types/selectors/BaseSelectorContainer.java
  implement the add(FileSelector) method

src/main/org/apache/tools/ant/types/selectors/SelectorContainer.java
  add an add(FileSelector) method


========================================= 
=   New Files  
========================================= 

src/etc/testcases/types/addtype.xml
  testcases for addtype

src/testcases/org/apache/tools/ant/types/AddTypeTest.java
  test cases for add type

Mime
View raw message