ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peter reilly <peter.rei...@corvil.com>
Subject Re: antlib / proposal of Peter Reilly
Date Wed, 14 May 2003 11:05:30 GMT
On Wednesday 14 May 2003 08:50, Antoine Levy-Lambert wrote:
> I am having a look at
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19897
>
> This proposal seems to address most of the points discussed in this mailing
> list concerning the antlib thread of discussion.
>
> I was thinking maybe we do not need to look further and we could commit
> this contribution ?

I think it should be looked at before committing ;-)...
I unified the type and task hashmaps in componentHelper to support the adapter
idea for typedef. This may have consequences for current external third party
ant tasks.

>
> I would be glad to hear your comments concerning :
> 1) the functionality provided by the contribution
> 2) the implementation
> I am quoting Peter Reilly here :
>
> This patch adds 4 new features (the code is interrelated,
> but may be split).
>   * adapter attribute added to typedef
>   * add(Type) method added to introspection rules
>   * typedef can read an xml defintion file
>   * namespace support for xml defintions (antlib:)
> So one can do
> <project xmlns:acme="org.acme.anttasks">

^^^ opps - that should be <project xmlns:acme="antlib:org.acme.anttasks">

>    <acme:hello>
>       <path path="build.xml"/>
>    </acme:hello>
> </project>
> where the class path contains the org/acme/anttasks/antlib.xml
> and the antlib.xml file contains:
> <antlib>
>    <typedef name="hello" classname="org.acme.anttasks.Hello"/>
> </antlib>
>
>
> ToDo: add in support for ant-type polymorphism and addConfigured(Type).
>       also more error checking and unit tests.
>

Peter


Mime
View raw message