ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peter reilly <peter.rei...@corvil.com>
Subject Re: Roles (was: antlib)
Date Tue, 29 Apr 2003 12:44:10 GMT
On Tuesday 29 April 2003 13:12, Stefan Bodewig wrote:
>
> I think the learning curve for beginners to grok
>
> <copy ...>
>   <classfileset .../>
>   <zipfileset .../>
> </copy>
>
> is steeper than the alternative
>
> <copy ...>
>   <fileset type="classfileset" .../>
>   <fileset type="zipfileset" .../>
> </copy>

This is debatable as the new type can take completly different attributes
and nested elements. Beginners would get equally confused by both
options.

>
> I'm not really sure myself, I've argued the first approach myself when
> we discussed it the last time around (because the non-ambiguos case
> requires less typing 8-)

I think we should allow both approaches. Each is valid for some set
of use cases.

For example <condition/> takes a set of conditions,
it makes sense for new conditions to be added "cleanly" :
<condition>
    <outofdate .../>
</condition>

Rather than (to take a perverse example)
<condition>
    <os type="outofdate">
        <targetfiles...
</condition>

This could be stopped by having two new introspection rules:
  
  6. public void addOverridableNestedElement(NestedElement anInner)
  7. public void addOverridableConfiguredNestedElement(NestedElement anInner)

But this does mean changing public methods

Peter


Mime
View raw message