ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Conor MacNeill <co...@cortexebusiness.com.au>
Subject Re: cvs commit: ant/src/main/org/apache/tools/ant/types ZipFileSet.java defaults.properties
Date Fri, 18 Apr 2003 23:34:06 GMT
On Sat, 19 Apr 2003 08:02 am, antoine@apache.org wrote:
> antoine     2003/04/18 15:02:59
>
>   Index: Zip.java
>   ===================================================================
>   RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/Zip.java,v
>   retrieving revision 1.103
>   retrieving revision 1.104
>   diff -u -r1.103 -r1.104
>   --- Zip.java	27 Mar 2003 10:02:04 -0000	1.103
>   +++ Zip.java	18 Apr 2003 22:02:58 -0000	1.104
>   @@ -67,7 +67,6 @@
>    import java.util.Vector;
>    import java.util.zip.CRC32;
>    import java.util.zip.ZipFile;
>   -import java.util.zip.ZipInputStream;
>
>    import org.apache.tools.ant.BuildException;
>    import org.apache.tools.ant.DirectoryScanner;
>   @@ -541,10 +540,10 @@
>            ZipFileSet zfs = null;
>            if (fileset instanceof ZipFileSet) {
>                zfs = (ZipFileSet) fileset;
>   -            prefix = zfs.getPrefix();
>   -            fullpath = zfs.getFullpath();
>   -            dirMode = zfs.getDirMode();
>   -            fileMode = zfs.getFileMode();
>   +            prefix = zfs.getPrefix(getProject());
>   +            fullpath = zfs.getFullpath(getProject());
>   +            dirMode = zfs.getDirMode(getProject());
>   +            fileMode = zfs.getFileMode(getProject());
>            }
>

Passing the project around like this should not be necessary since the 
zipfileset is a ProjectComponent and should have its own project reference. 
Hmmm, it may even be a different project instance.

Conor



Mime
View raw message