ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Conor MacNeill <co...@cortexebusiness.com.au>
Subject Re: cvs commit: ant/src/main/org/apache/tools/ant Location.java
Date Tue, 01 Apr 2003 01:21:11 GMT
On Tue, 1 Apr 2003 01:08 am, bodewig@apache.org wrote:
> bodewig     2003/03/31 07:08:37
>
>   Modified:    src/main/org/apache/tools/ant Location.java
>   Log:
>   unURIfy build-file name if necessary.
>
>    /**
>   @@ -118,7 +119,11 @@
>         * @param columnNumber Column number within the line.
>         */
>        public Location(String fileName, int lineNumber, int columnNumber) {
>   -        this.fileName = fileName;
>   +        if (fileName != null && fileName.startsWith("file:")) {
>   +            this.fileName = FileUtils.newFileUtils().fromURI(fileName);
>   +        } else {
>   +            this.fileName = fileName;
>   +        }
>            this.lineNumber = lineNumber;
>            this.columnNumber = columnNumber;
>        }
>

I was about to commit a slightly different fix for this. Rather than change 
filename on the way in, I changed it on the way out in the toString method. 
Just wondering if the names within the location object should be consistent 
(i.e. always URLs). Currently moot, I guess.

Conor


Mime
View raw message