ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Magesh Umasankar" <umag...@apache.org>
Subject Re: cvs commit: ant/src/main/org/apache/tools/ant/types/selectors ExtendSelector.java
Date Tue, 15 Apr 2003 00:33:12 GMT
----- Original Message -----
From: "Conor MacNeill" <conor@cortexebusiness.com.au>
To: "Ant Developers List" <dev@ant.apache.org>
Sent: Monday, April 14, 2003 8:05 PM
Subject: Re: cvs commit: ant/src/main/org/apache/tools/ant/types/selectors
ExtendSelector.java


> I have some questions about this patch
>
> On Tue, 15 Apr 2003 03:21 am, umagesh@apache.org wrote:
> >   +            Project.setProjectOnObject(project, o);
>
> Why is this a static method rather than a plain method like this:
> project.setProjectOnObject(o);

I really have no good answers to this one.  Do you prefer one
over the other in this case?

> Why don't we define an interface for all things that can have a Project
> instance (Projectable :-)) rather than using reflection? It could be
applied
> to ProjectComponent.

+1

> Conor

Cheers,
Magesh



Mime
View raw message