ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peter reilly <peter.rei...@corvil.com>
Subject Re: Artima SuiteRunner Task
Date Thu, 27 Mar 2003 10:13:21 GMT
Costin Manolache wrote:
> > I would include filters, mappers, conditions and selectors to
> > the list.
>
> I would exclude them :-)
>
> Taks, types, mappers, filters, whatever are just ant components -
> and they shouldn't need a special syntax from user perspective.

That is what I meant to say.....

>
> We shouldn't treat them ( or types, tasks ) as special - just plain
> components that happen to perform different functions in the build file.

agreed..
>
> > A relatively simple mod to the core ant makes this
> > possible (bugzilla 17199) basically get ConditionBase.java,
> > AbstractFileSet, FilterChain implement DynamicConfigurator.
> > and get UnknownElement (bugzilla 18312) call setProject
> > earlier on created children.
> > Mappers are a little different, I implemented a new
> > attribute to handle this.
>
> That's a possible solution, I'll take a look ( in few weeks
> unfortunately..., hopefully this will be resolved by than by others :-).
>
>
> From the point of view of the reader ( assuming we go with the SAX2
> ProjectHelperImpl ) - it really doesn't matter what the component does.
>
> The only problem in the current code is the TaskAdapter - which doesn't
> know about types and other components, and tries to wrap everything.

This does not seem to matter (if use is made
of dynconfigurator). The only change I had to do was to
get UnknownElement to call setProject on created objects. 
(my original mod to TaskAdapter was not sufficient)

Peter.

Mime
View raw message