Return-Path: Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Delivered-To: mailing list dev@ant.apache.org Received: (qmail 22509 invoked from network); 26 Feb 2003 15:05:26 -0000 Received: from bodewig.bost.de (195.227.98.11) by daedalus.apache.org with SMTP; 26 Feb 2003 15:05:26 -0000 Received: (from bodewig@localhost) by bodewig.bost.de (8.11.6/8.11.6) id h1QF5RX25934; Wed, 26 Feb 2003 16:05:27 +0100 X-Authentication-Warning: bodewig.bost.de: bodewig set sender to bodewig@apache.org using -f To: dev@ant.apache.org Subject: Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/cvslib ChangeLogTask.java References: <20030221001922.47616.qmail@icarus.apache.org> <20030221001922.47616.qmail@icarus.apache.org> <5.2.0.9.2.20030221080004.066d4360@mail.comcast.net> From: Stefan Bodewig Date: 26 Feb 2003 16:05:27 +0100 In-Reply-To: <5.2.0.9.2.20030221080004.066d4360@mail.comcast.net> Message-ID: Lines: 22 User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Military Intelligence) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Fri, 21 Feb 2003, Ken Gentle wrote: > The justification for the new parameters is maintaining the > interface for any extensions of the ChangeLogTask. I don't think > the class is very amenable to subclassing (all the interesting > methods and attributes are private), and continuing to depend on the > IntrospectionHelper's use of a deprecated API seems risky. Not only subclassing but delegation as well. We once changed Available's setFile method to take a String argument instead of a File argument. Gump told us that something inside Castor's build (IIRC) created an Available instance and called setFile(File) on it. What we've learned by that is that we can never be sure that nobody uses our public API. I'm rather leaning towards separate attributes and preserving the old signatures as well. Stefan