ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/cvslib ChangeLogTask.java
Date Wed, 26 Feb 2003 15:05:27 GMT
On Fri, 21 Feb 2003, Ken Gentle <j.kenneth.gentle@acm.org> wrote:

> The justification for the new parameters is maintaining the
> interface for any extensions of the ChangeLogTask.  I don't think
> the class is very amenable to subclassing (all the interesting
> methods and attributes are private), and continuing to depend on the
> IntrospectionHelper's use of a deprecated API seems risky.

Not only subclassing but delegation as well.

We once changed Available's setFile method to take a String argument
instead of a File argument.  Gump told us that something inside
Castor's build (IIRC) created an Available instance and called
setFile(File) on it.

What we've learned by that is that we can never be sure that nobody
uses our public API.

I'm rather leaning towards separate attributes and preserving the old
signatures as well.

Stefan

Mime
View raw message