ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 17199] - patch to allow custom conditions (+ filters..)
Date Fri, 21 Feb 2003 18:35:34 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17199>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17199

patch to allow custom conditions (+ filters..)





------- Additional Comments From peter.reilly@corvil.com  2003-02-21 18:35 -------
Thanks for your comments. 
 
a) 
I initially had a conditiondef, fiterdef, mapperdef and selectordef, they were basicly the

same as typedef and taskdef. The code was a cut and paste of 
the code for typedef - in ant/Project.java. It just looked a bit silly 
to have 6 maps of definititons. After looking at the code in 
ant/ComponentHelper.createComponent(), the comments suggested that in the 
future the difference between tasks and datatypes would disappear, I realized that 
if I used typedefs, it would probally fit in better to the way ant is meant to work - 
and a lot of code disappears (which is also a good thing). 
 
b) I would have to agree on the mapper mod, initialy I did have a seperate 
   attribute, but I could not think of a good name for it. The change I made 
   will affect custom extensions that use the mapper class, but it does not 
   affect build scripts.

Mime
View raw message