ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 17296] New: - jarlib-manifest : vendor information are swapped
Date Fri, 21 Feb 2003 18:02:08 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17296>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17296

jarlib-manifest : vendor information are swapped

           Summary: jarlib-manifest : vendor information are swapped
           Product: Ant
           Version: 1.5.1
          Platform: PC
        OS/Version: Windows NT/2K
            Status: NEW
          Severity: Major
          Priority: Other
         Component: Optional Tasks
        AssignedTo: dev@ant.apache.org
        ReportedBy: raphael.petit@free.fr


There's a funny feature (looks like a bug)
in the classe
org.apache.tools.ant.taskdefs.optional.extension.ExtensionAdapter
in the method Extension toExtension()

I feel more confortable if someone swap the 'error' commented lines below (see 
the Extension constructor).

best regards

************************************************
***********  source of 
org.apache.tools.ant.taskdefs.optional.extensionExtensionAdapter
************************************************
 Extension toExtension()
    throws BuildException
{
    if( null == m_extensionName )
    {
        final String message = "Extension is missing name.";
        throw new BuildException( message );
    }

    String specificationVersion = null;
    if( null != m_specificationVersion )
    {
        specificationVersion = m_specificationVersion.toString();
    }
    String implementationVersion = null;
    if( null != m_implementationVersion )
    {
        implementationVersion = m_implementationVersion.toString();
    }
    return new Extension( m_extensionName,
                          specificationVersion,
                          m_specificationVendor,
                          implementationVersion,
                          m_implementationVendorID,  // error
                          m_implementationVendor,    // error
                          m_implementationURL );
}
************************************************
***********  source of 
org.apache.tools.ant.taskdefs.optional.extension.Extension
************************************************
public Extension( final String extensionName,
  final String specificationVersion,
  final String specificationVendor,
  final String implementationVersion,
  final String implementationVendor,
  final String implementationVendorId,
  final String implementationURL
  {
     m_extensionName = extensionName;
     m_specificationVendor = specificationVendor;
     if( null != specificationVersion )

Mime
View raw message