ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 16780] - copy with <filterset> corrupts binary files
Date Tue, 04 Feb 2003 23:11:12 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16780>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16780

copy with <filterset> corrupts binary files





------- Additional Comments From smagoun@mac.com  2003-02-04 23:11 -------
There's absolutely nothing in the Filterset docs that indicates that they should
only be used on text files. I appreciate that there's a warning (bold text,
even!) in the "Using Ant:Token Filters" section. That section doesn't mention
filtersets, though, so anyone who greps for "filterset" will miss the warning. 

Furthermore, there's no warning on the Filterset documentation page itself
/manual/CoreTypes/filterset.html) or even in the docs for the copy task.

The "Using Ant" page is very helpful for newbies, but for people who've been
using ant for a long time the actual task docs are the place to start, not the
"Using Ant" page.

My request: If filterset is indeed behaving properly by munging my binary files,
please document that behavior on the filterset page of the manual! IMHO that
behavior violates the Law of Least Astonishment, and therefore merits some
documentation.

Gus: I can make the copy in 2 passes (binaries, then text-only), but that's a
real pain to do and it's fragile. It's also twice as much code to maintain.
Instead I copy everything, and then used the replace task to do the filtering.
It's a bit ugly, but it works. So much for filtersets...

Mime
View raw message