Return-Path: 
 <ant-dev-return-41137-qmlist-jakarta-archive-ant-dev=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-ant-dev-archive@apache.org
Received: (qmail 81923 invoked from network); 13 Jan 2003 16:56:26 -0000
Received: from exchange.sun.com (192.18.33.10)
  by daedalus.apache.org with SMTP; 13 Jan 2003 16:56:26 -0000
Received: (qmail 17717 invoked by uid 97); 13 Jan 2003 16:57:40 -0000
Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org
Received: (qmail 17631 invoked by uid 97); 13 Jan 2003 16:57:39 -0000
Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:ant-dev-unsubscribe@jakarta.apache.org>
List-Subscribe: <mailto:ant-dev-subscribe@jakarta.apache.org>
List-Help: <mailto:ant-dev-help@jakarta.apache.org>
List-Post: <mailto:ant-dev@jakarta.apache.org>
List-Id: "Ant Developers List" <ant-dev.jakarta.apache.org>
Reply-To: "Ant Developers List" <ant-dev@jakarta.apache.org>
Delivered-To: mailing list ant-dev@jakarta.apache.org
Received: (qmail 17569 invoked by uid 98); 13 Jan 2003 16:57:36 -0000
X-Antivirus: nagoya (v4218 created Aug 14 2002)
Message-ID: <3E22EF93.5030908@apache.org>
Date: Mon, 13 Jan 2003 17:55:47 +0100
From: Nicola Ken Barozzi <nicolaken@apache.org>
Reply-To: nicolaken@apache.org
Organization: Apache Software Foundation
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
 rv:1.2.1) Gecko/20021130
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Ant Developers List <ant-dev@jakarta.apache.org>
Subject: Re: Improt task and project basedir
References: <FCA94FF996325842AACD9E80DBC2CA1F045CF12C@exch-sl02.mdli.com>
In-Reply-To: <FCA94FF996325842AACD9E80DBC2CA1F045CF12C@exch-sl02.mdli.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N


Alexey Solofnenko wrote:
> Hello Nicola,

Hi Alex. Happy to hear again from you on this :-)

> Externally loaded properties can be prefixed, since <property file=""/> and
> <xmlproperty> have "prefix" attributes, but externally loaded properties
> cannot be rebased in pre-processor, only in ANT itself. I had to provide a
> "project.root" property to ANT and use it in all externally loaded property
> files for path properties to work correctly.

It can be done probably if we tweak the new PropertyHelper to get a 
value from the Project that tells him if he has to prefix the value or 
not when inserting it. It should work with all variables.

> Property rebasing requires some discipline from a build writer. That means
> all path properties should be in <property location=""/> form. Sometimes a
> property can be used in both string and path context. That is why the real
> string property is not rebased, but a shadow rebased property should be
> created:
> <property name="some-dir" value="build"/>
> 
> <fileset dir="${some-dir}/.." includes="${some-dir}"/>
> 
> is translated into something like:
> 
> <property name="some-dir" value="build"/>
> <property name="some-dir~~rebased"
> location="${**rebased-base-dir**}/build"/> 
> <fileset dir="${some-dir~~rebased}/.." includes="${some-dir}"/>

Ahh, now I get it. Interesting. Yes, it still needs discipline from 
writers but the file can be truly indipendent from importing or not.

> ANT itself can be changed to save three kinds of values for each property -
> a string value, path value and path list value. In that case no magical
> names are needed.

I'm not sure I get this...

Anyway, it can be done IIUC in PropertyHelper in the same way we make 
prefixes.

> In case of one property uses another rebased property it does not have to be
> changed at all.
> 
> I think that dropping property rebasing will leave build writing still
> inconvenient.

I'm trying to weight costs and benefits. Seems like th ebenefits are 
going up and the costs down! :-)

-- 
Nicola Ken Barozzi                   nicolaken@apache.org
             - verba volant, scripta manent -
    (discussions get forgotten, just code remains)
---------------------------------------------------------------------


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>