ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Conor MacNeill <co...@cortexebusiness.com.au>
Subject Re: signjar task OutOfMemoryError
Date Tue, 14 Jan 2003 22:28:55 GMT
Jim Garacci wrote:
> I did a little investigation into this, i.e. I did a cvs checkout of the 
> source, and noticed that someone added a "maxmemory" attribute to 
> SignJar on 12/23. 
> <hat style="manager">
>    I did not, however, find a bug entry for this.  

Since you have a manager hat on, I guess that it is understandable that 
you couldn't find it :-)

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=1284

If you look at the CVS commit log, it also mentions the bugzilla numbers 
there.

> Not yet having 
> contributed to an open source project, is it standard practice for the 
> opensource community to just submit code fixes without recording 
> bug/enhancement entries in bugzilla?  

We do not require an entry in BugZilla to add or fix code in the Ant 
codebase.

> <hat style="qa">
>    Why was the attribute not named "memoryMaximumSize" as it was for 
> javac for consistancy purposes?
>    Why was a "memoryMinimumSize" attribute not added, again for 
> consistancy?

It is consistent with the <javadoc> task.

>    Why was the Java class attribute not made all lower case to match the 
> rest of the source in the file?
> </hat>

The rest of the code is wrong :-) The coding conventions we use require 
variables to be camelCase, not all lowercase. However, since these 
variables are "protected" (which is really also a bad idea), I can not 
correct this.

> 
> Regardless, is there anyway to check on the status of this fix and its 
> possible inclusion in 1.5.2 or 1.6?

Yes, refer to the BugZilla case above

Conor



--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message