ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig Campbell" <ccampb...@novell.com>
Subject Re: cvs commit: jakarta-ant-antidote/src/java/org/apache/tools/ant/gui/modules/edit DependentTargetChoos
Date Mon, 02 Dec 2002 18:13:18 GMT
Chris,
 
I noticed that you committed something for Antidote.  I was wondering if you could take a
look at Bug 14138 (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14138) where I have requested
a few enhancements to Antidote, but haven't heard anything from anybody on where this is headed,
or what more I need to do to get this committed.
 
Thanks for looking into this for me,
Craig

>>> chrisw@apache.org 11/24/2002 5:54:15 AM >>>

chrisw      2002/11/24 04:54:15

  Modified:    src/java/org/apache/tools/ant/gui/modules/edit
                        DependentTargetChooser.java
  Log:
  Fixed Bug in dependency checking.
  
  Revision  Changes    Path
  1.3       +3 -4      jakarta-ant-antidote/src/java/org/apache/tools/ant/gui/modules/edit/DependentTargetChooser.java
  
  Index: DependentTargetChooser.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ant-antidote/src/java/org/apache/tools/ant/gui/modules/edit/DependentTargetChooser.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- DependentTargetChooser.java    4 May 2001 18:55:19 -0000    1.2
  +++ DependentTargetChooser.java    24 Nov 2002 12:54:15 -0000    1.3
  @@ -198,13 +198,12 @@
           DOMNodeList allNodes = parentProject.getChildNodes();
           ArrayList retVal = new ArrayList();
           int length = allNodes.getLength();
  -        for (int i = 0; i < length; i++)
  -        {
  +        for (int i = 0; i < length; i++) {
               DOMNode node = allNodes.item(i);
               if (node instanceof ACSTargetElement) {
                   ACSTargetElement currentElement = ((ACSTargetElement)node);
                   // ... leave out the current target TODO: avoid cyclic relations!
  -                if (currentElement != aTarget) retVal.add(currentElement);
  +                if (!currentElement.getName().equals(aTarget.getName())) retVal.add(currentElement);
               }
           }
           return retVal;
  
  
  

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>




Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message