ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Craeg K Strong <cstr...@arielpartners.com>
Subject Re: [PATCH] XMLCatalog testcase fix
Date Mon, 02 Dec 2002 03:46:00 GMT
Thanks, Jeff!

I am +1 on your testing patches.

I wrestled with the logging level myself.

I think its ok for MSG_DEBUG -- although you will likely get tons
of output, the resolver message is distinctive enough that you can grep
for it...

--Craeg

Jeff Turner wrote:
> Hi,
> 
> Poking around the XMLCatalog stuff, I've found:
> - The external catalog support isn't tested when 'build.sh test' is run,
>   because resolver.jar isn't in the test classpath.
> - Even though there is no external catalog support, the 'xmlvalidate.xml'
>   test script still works, because it is designed to pass whether or not
>   support is present.
> - If support is added, the script breaks because the referenced file,
>   src/etc/testcases/taskdefs/optional/xml/catalog does not exist.
> 
> 
> Attached is a small patch which creates the missing catalog file, and
> makes manual runs more interesting:

<snip/>


> And while I was at it, those messages about which resolver is used get
> rather annoying, and are only useful when debugging, so the second patch
> turns their logging level down to MSG_DEBUG.
> 
> 
> --Jeff


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message