ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: [PATCH] Adding Dynamic elements for the n'th time
Date Fri, 29 Nov 2002 07:32:14 GMT
On Thu, 28 Nov 2002, Magesh Umasankar <umagesh@apache.org> wrote:

> I don't see addXXXPath(...) methods in <javac>.  I only see
> createXXXPath().

My fault, sorry.

Let's step away from implementation details and assume that <javac>
used the addXXX variety of things for its <src> and <classpath>
child-elements.  Both take Path arguments as both are our usual
path-like structures.

I now invent a Path subclass with a terrific new feature (no matter
what) and call it MyPath.  I register it as a data-type with the name
mypath.  How would I write the <javac> task if I wanted to pass a
MyPath instance as <src>?  How if I wanted to pass it as <classpath>?

Conor's suggestion would be <classpath xsd:type="mypath"/> or
<src xsd:type="mypath"/>.

Dominique says you could turn that around <mypath xsd:type="classpath"/>
or <mypath xsd:type="src"/> - which I find easier to read, especially
since you could leave out the type attribute in situations that are
not ambiguous.  But then again, it is an abuse of XML Schema as I read
it the same way as Conor is using the type attribute.

IIUC your current patch wouldn't handle a situation like this at all
(no offence, I just want to get things clear), but would be like
Dominque's suggestion in cases that are not ambiguous.

Maybe we can simply agree on how to handle the more complicated case
and then extend your patch to that?  No reason to hold it back,
though.

Stefan

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message