ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: [PATCH] Adding Dynamic elements for the n'th time
Date Thu, 28 Nov 2002 10:54:06 GMT
On Wed, 27 Nov 2002, Magesh Umasankar <umagesh@apache.org> wrote:

> This, I think is a reasonable constraint if you plan
> to be doing different things (obviously) in addSrc and
> addClasspath.

I disagree.  Just look into the current implementation of <javac>,
there are several path structures supported via nested elements.
Inventing a Path subclass for all of them seems overkill.

And even then, take MyPath extends Src extends Path and addSrc(Src) as
well as AddPath(Path) - what should <mypath> trigger?

I think we really need a way for the user to disambiguate the
situation.

One way is to say <path> when I want addPath and <src> when I want
addSrc (and use an attribute to say it it a MyPath).  I think this
might involve major changes in IntrospectionHelper.

The other way is to say <mypath> and have an attribute that says "use
this as path" or "use this as "src".  This also means big changes to
IntrospectionHelper, but potentially smaller ones.

I'm just estimating here.

Stefan

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message