ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dominique Devienne <DDevie...@lgc.com>
Subject RE: [PATCH] adds 'if'/'unless' to <antcall> (CallTarget.java)
Date Mon, 25 Nov 2002 16:24:55 GMT
I'm +1 too, especially since I submitted a patch to do just that a few
months back! It added if/unless attributes, and a nested <condition> to
generalize the concept. The latter part people like Diane didn't like too
much, and we discussed having a 'conditionref' attribute instead. --DD

-----Original Message-----
From: Costin Manolache [mailto:cmanolache@yahoo.com] 
Sent: Monday, November 25, 2002 9:39 AM
To: ant-dev@jakarta.apache.org
Subject: RE: [PATCH] adds 'if'/'unless' to <antcall> (CallTarget.java)

Lach, Thierry wrote:

> Is there any problem with adding the 'if' and 'unless' handling to
> org.apache.tools.ant.Task thereby giving the capability to every single
> task rather than continuing to add it to each task individually?

I wouldn't mind if/unless at Task level. I've seen a lot of complexity
trying to get around this.

I'm +1 on having a consistent behavior on all tasks.

Costin


> 
> -----Original Message-----
> From: MNewcomb@tacintel.com [mailto:MNewcomb@tacintel.com]
> Sent: Friday, November 22, 2002 4:17 PM
> To: ant-dev@jakarta.apache.org
> Subject: [PATCH] adds 'if'/'unless' to <antcall> (CallTarget.java)
> 
> 
> <antcall> needs a way to be called conditionally.
> 
> This patch adds two attributes to <antcall>, 'if' and 'unless'.  They
> work the same way as they do in <target>.
> 
> I found this useful when creating a set of targets specifically designed
> to be invoked via <antcall>.
> 
> Please review, [comment], and apply this patch if acceptable.
> 
> Thanks,
> Michael




--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message