ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Turner <je...@apache.org>
Subject [PATCH] XMLCatalog testcase fix
Date Sat, 30 Nov 2002 14:39:02 GMT
Hi,

Poking around the XMLCatalog stuff, I've found:
- The external catalog support isn't tested when 'build.sh test' is run,
  because resolver.jar isn't in the test classpath.
- Even though there is no external catalog support, the 'xmlvalidate.xml'
  test script still works, because it is designed to pass whether or not
  support is present.
- If support is added, the script breaks because the referenced file,
  src/etc/testcases/taskdefs/optional/xml/catalog does not exist.


Attached is a small patch which creates the missing catalog file, and
makes manual runs more interesting:

[jakarta-ant ~/src/etc/testcases/taskdefs/optional]$ ~/dist/bin/ant -f xmlvalidate.xml
Buildfile: xmlvalidate.xml

testValidate:
Apache resolver library found, xml-commons resolver will be used
[xmlvalidate] 1 file(s) have been successfully validated.

testDeepValidate:

testValidate:
Apache resolver library found, xml-commons resolver will be used
[xmlvalidate] 1 file(s) have been successfully validated.

xmlcatalog:
Apache resolver library found, xml-commons resolver will be used
[xmlvalidate] 1 file(s) have been successfully validated.

xmlcatalognested:
Apache resolver library found, xml-commons resolver will be used
[xmlvalidate] 1 file(s) have been successfully validated.

xmlcatalogfiles:
Apache resolver library found, xml-commons resolver will be used
[xmlvalidate] 1 file(s) have been successfully validated.

testSchemaGood:
[xmlvalidate] 1 file(s) have been successfully validated.

testIso2022Jp:
[xmlvalidate] 1 file(s) have been successfully validated.

testGoodUns:

BUILD SUCCESSFUL
Total time: 4 seconds


And while I was at it, those messages about which resolver is used get
rather annoying, and are only useful when debugging, so the second patch
turns their logging level down to MSG_DEBUG.


--Jeff


Mime
View raw message