ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Magesh Umasankar" <umag...@apache.org>
Subject Re: [PATCH] reenable jar's filesetmanifest
Date Thu, 21 Nov 2002 21:47:22 GMT
Patch applied to cvs.  Thanks!

Please test drive it and see ensure I haven't messed
things up.

Cheers,
Magesh

----- Original Message -----
From: "Brian Deitte" <bdeitte@macromedia.com>
To: <ant-dev@jakarta.apache.org>
Sent: Thursday, September 26, 2002 1:51 PM
Subject: [PATCH] reenable jar's filesetmanifest


> Hi, I finally got around to reenabling the filesetmanifest attribute on
the jar task.  This was disabled since in this case the manifest was not
written to the zip file first, and this causes problems with JarInputStream.
>
> I started to fix this bug by refactoring the Zip class so that the fileset
parsing pieces were in a different class... but this was taking to long.  I
have the unfinished code around (50-75% done) if anybody wants to try it
themselves.  I ended up adding code to the Zip class that allows two passes
on the filesets, with the first pass not writing anything out to the
outputstream.  This allows all the manifest information to be gathered up
and written first on the second pass.  I ran the appropriate tests and tried
some cases out myself.  Diffs attached.  -Brian
>



--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message