ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott Stirling" <scottstirl...@rcn.com>
Subject RE: [PATCH] proposal for ant.taskdefs.optional.jsp.WLJspc
Date Fri, 22 Nov 2002 05:34:03 GMT
Looks good.  I'm not a committer, but I've had changes committed before.
I would recommend documenting your changes, and especially providing
updates to the manual page for the task.  Just attaching a diff and
alluding to "improvements" is a little vague.  Besides, your
underselling some nice contributions!

Some of the things I noticed and would like to call out:
- support for nested fileset (nice!)
- support for -verbose flag
- support for -compilerclass flag
- support for -classpath and -bootclasspath flags
- support for switching fileEncoding String (the "_" vs. "__" jsp class
file prefix issue)
- refactorings related to above changes

Two questions:
- changed args array to a Vector (why?  Just curious)
- What do you think of changing the end-user attribute for the
fileEncoding String (the "_" vs. "__" jsp class file prefix issue) to
something like "weblogicversion" or, at least, documenting the
significance of this attribute in the HTML manual.

Anyway, looks good.  We could use these changes on the job.

Scott Stirling

> -----Original Message-----
> From: David Emerson [mailto:demerson@spindrift.com] 
> Sent: Sunday, November 17, 2002 11:22 AM
> To: ant-dev@jakarta.apache.org
> Subject: [PATCH] proposal for ant.taskdefs.optional.jsp.WLJspc
> 
> 
> I recently had a need to get the weblogic jspc task working for a 
> project I work on. I made quite a number of improvements that 
> I believe 
> are compatible with the existing optional task and I'd like 
> to submit it 
> back to the Ant project for your consideration.  Let me know 
> if there's 
> anything else that I need to do to submit a patch proposal to 
> Ant. Dave Emerson
> 



--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message