Return-Path: 
 <ant-dev-return-37440-qmlist-jakarta-archive-ant-dev=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-ant-dev-archive@apache.org
Received: (qmail 95082 invoked from network); 2 Sep 2002 10:48:53 -0000
Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131)
  by daedalus.apache.org with SMTP; 2 Sep 2002 10:48:53 -0000
Received: (qmail 18425 invoked by uid 97); 2 Sep 2002 10:49:19 -0000
Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org
Received: (qmail 18390 invoked by uid 97); 2 Sep 2002 10:49:19 -0000
Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:ant-dev-unsubscribe@jakarta.apache.org>
List-Subscribe: <mailto:ant-dev-subscribe@jakarta.apache.org>
List-Help: <mailto:ant-dev-help@jakarta.apache.org>
List-Post: <mailto:ant-dev@jakarta.apache.org>
List-Id: "Ant Developers List" <ant-dev.jakarta.apache.org>
Reply-To: "Ant Developers List" <ant-dev@jakarta.apache.org>
Delivered-To: mailing list ant-dev@jakarta.apache.org
Received: (qmail 18374 invoked by uid 98); 2 Sep 2002 10:49:18 -0000
X-Antivirus: nagoya (v4218 created Aug 14 2002)
X-Authentication-Warning: bodewig.bost.de: bodewig set sender to
 bodewig@apache.org using -f
To: ant-dev@jakarta.apache.org
Subject: Re: DynamicConfigurator passing fully qualified class name
References: <28336AC23B25D411BEA300105AC7F5441199A601@ICEXCH2>
From: Stefan Bodewig <bodewig@apache.org>
Date: 02 Sep 2002 12:48:39 +0200
In-Reply-To: <28336AC23B25D411BEA300105AC7F5441199A601@ICEXCH2>
Message-ID: <m31y8cu0oo.fsf@bodewig.bost.de>
Lines: 24
User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Honest Recruiter)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

On Wed, 21 Aug 2002, John-Mason Shackelford <ShacJo@ncs.com> wrote:

> All I was suggesting is that IntrospectionHelper.createElement could
> check to see of the tag is already associated with a class via
> <typedef> or <taskdef> and, if so, pass in a FQN to
> DynamicConfigurator.createDynamicElement(String name) since that
> will reduce ambiguity.

I'd guess that you would not want that to happen in some cases like
where junit was a DynamicConfigurator and couldn't provide its own
<test> child because there already is a <test> task.

Also, there are tasks that map to more than one name, so you'd lose
information (which tag has actually been used?).

> On second thought, perhaps it would be better to have a signature
> DynamicConfigurator.createDynamicElement(ProjectComponent pc)and
> pass in an instantiated ProjectComponent when we can do so instead
> of calling the signature that takes a String.

Same problems as above IMHO and neither tasks nor data types are
forced to extend ProjectComponent.

Stefan

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>