ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erik Hatcher <jakarta-...@ehatchersolutions.com>
Subject Re: [VOTE] Porting <fileset> 'file' attribute to 1.5 branch
Date Mon, 02 Sep 2002 13:08:00 GMT
Will do.

How could I gotten so much wrong in two lines of code?!  :))

Stefan Bodewig wrote:
> Trying to get up to speed, you mean this one?
> <http://cvs.apache.org/viewcvs.cgi/jakarta-ant/src/main/org/apache/tools/ant/types/AbstractFileSet.java.diff?r1=1.9&r2=1.10>
> 
> If you 
> 
> (1) make it JDK 1.1 compatible by using FileUtils#getParentFile
> instead of File#getParentFile 8-)
> 
> (2) use createInclude instead of setIncludes so that it works for
> filenames that contain spaces.
> 
> +1
> 
> Stefan
> 
> 
> --
> To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>
> 
> 
> 



--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message