ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 12632] - [PATCH] New <lsync> to synchronize a local directory from one or more <fileset>s
Date Mon, 16 Sep 2002 16:31:41 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12632>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12632

[PATCH] New <lsync> to synchronize a local directory from one or more <fileset>s





------- Additional Comments From bodewig@apache.org  2002-09-16 16:31 -------
So you think it will bubble up my patch queue faster if you do as I say instead
of convincing my that your way is correct? ;-)

Seriously.  If I had written that task, I would have taken an entirely different
route (and ended up scanning each directory at least twice instead
of once 8-), something that delegates to <copy> and <delete>, each using
<present> selectors under the covers.  Your approach is superior to that.

OK, instead of using Project#createTask (I see you've done what CallTarget
does), I'd probably instantiate the subclass directly, call setProject on it
and that's it.  I'd assume you don't need to set the owning target or the 
task's name, but I may be wrong in the presence of BuildListeners.

Give us a testcase, pretty please 8-)

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message