ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: cvs commit: jakarta-ant/src/script ant antRun
Date Fri, 09 Aug 2002 07:15:00 GMT
On 8 Aug 2002, <costin@apache.org> wrote:

>   1. Removes the extraneous "cd `dirname $PRG`" line
>   
>   3. Invoke Java using the "exec" shell command.

Has this been tested under Cygwin?

I'm not sure whether exec works as expected there and cannot test it,
that's why I've kept away from that patch.

Also

>   @@ -167,7 +165,6 @@
>      if $cygwin ; then
>        JIKESPATH=`cygpath --path --windows "$JIKESPATH"`
>      fi
>   -  ANT_OPTS="$ANT_OPTS -Djikes.class.path=$JIKESPATH"
>    fi

<snip/>

>   -Djikes.class.path="$JIKESPATH" $ANT_OPTS

changes things a bit.  In the old version jikes.class.path would be
left unset if the environment variable JIKESPATH was unset (and you
are not on MacOS X).  Now this property will be always defined, but
may get an empty value.

There certainly is a difference between a property that is not set and
an empty one (see if/unless attributes) and the jikes compiler adapter
behaves differently as well:

        String jikesPath = System.getProperty("jikes.class.path");
        if (jikesPath != null) {
            classpath.append(new Path(project, jikesPath));
        }

which may lead to adding an empty entry to the classpath before
invoking jikes.

Could you please revert at least this last part of the patch?

Stefan

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message