ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Romin Irani <rir...@insyncinfo.com>
Subject [PATCH] - org.apache.ant.tools.listener.MailLogger
Date Wed, 07 Aug 2002 17:56:16 GMT
CURRENT ISSUE
-------------
There is no way for providing the SMTP port to the MailLogger. The
MailLogger uses the default constructor for MailMessage as a result of which
it is imperative that the SMTP port be running only on 25 (DEFAULT_PORT).

It would be good to provide an additional parameter in the
MailLogger.properties called MailLogger.port, so that one can also specify
the SMTP port # instead of just the host name (MailLogger.mailhost)

PATCH DETAILS
-------------
1) The MailLogger now checks for a property named MailLogger.port. If it is
not present, it defaults to MailMessage.DEFAULT_PORT.

2) The sendMail signature is now changed to accomodate a "port" parameter
also.

3) The sendMail method now does:
        MailMessage mailMessage = new MailMessage(mailhost, port);

   instead of
        MailMessage mailMessage = new MailMessage(mailhost);

Thanks,
Romin.


Mime
View raw message