ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephane Bailliez" <sbaill...@apache.org>
Subject Re: [PATCH] Can no longer build cvs tip
Date Tue, 20 Aug 2002 06:52:42 GMT
----- Original Message -----
From: "Brian DeWeese" <brd1_reuters@yahoo.com>

> Your reference to the scripts pointed me to the solution, I should
> have looked there earlier.  The problem is in ant.bat.  It jumps off
> to "checkJikes" even though the java.exe compiler exists and
> therefore bypasses the statements that append the rt.jar and
> tools.jar to the classpath.  I'd say it's missing a NOT.  I added
> that to my version and it fixed the problem.

Oops indeed, there's a problem here.
I did not noticed since I was using jikes.

> Also, I'm not sure why it would want to reset _JAVACMD to just
> "java.exe" when the "%JAVA_HOME%\bin\java.exe" version existed.  So,

legacy logic. It's a fallback. It's only if %JAVA_HOME%\bin\java.exe does
not exist, since it already jumped to jikes before, so you got it wrong in
your patch if you move it to checkJikes, it will be resetted in all cases
and you will get java from the path rather than from java home...not that
before that there was a difference between existence of java home and
existence of java.exe, since when there were no java home the fallback was
the path but it has been lost in the previous patch.

I will give it a look later...all this batch script thing is a miracle when
it works. Perl is even easier to read than batch files.

> I've changed the logic around that a bit and fixed a problem with the
> @endlocal if statement.
>
> I've attached a patch.  I hope you find it useful.

Thanks


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message