Return-Path: 
 <ant-dev-return-35486-qmlist-jakarta-archive-ant-dev=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-ant-dev-archive@apache.org
Received: (qmail 67101 invoked from network); 11 Jul 2002 07:00:46 -0000
Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131)
  by daedalus.apache.org with SMTP; 11 Jul 2002 07:00:46 -0000
Received: (qmail 8176 invoked by uid 97); 11 Jul 2002 07:00:58 -0000
Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org
Received: (qmail 8160 invoked by uid 97); 11 Jul 2002 07:00:57 -0000
Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:ant-dev-unsubscribe@jakarta.apache.org>
List-Subscribe: <mailto:ant-dev-subscribe@jakarta.apache.org>
List-Help: <mailto:ant-dev-help@jakarta.apache.org>
List-Post: <mailto:ant-dev@jakarta.apache.org>
List-Id: "Ant Developers List" <ant-dev.jakarta.apache.org>
Reply-To: "Ant Developers List" <ant-dev@jakarta.apache.org>
Delivered-To: mailing list ant-dev@jakarta.apache.org
Received: (qmail 8148 invoked by uid 98); 11 Jul 2002 07:00:57 -0000
X-Antivirus: nagoya (v4198 created Apr 24 2002)
Message-ID: <3D2D2D02.3000003@apache.org>
Date: Thu, 11 Jul 2002 09:00:18 +0200
From: Nicola Ken Barozzi <nicolaken@apache.org>
Reply-To: nicolaken@apache.org
Organization: Apache Software Foundation
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
 rv:1.0.0) Gecko/20020530
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Ant Developers List <ant-dev@jakarta.apache.org>
Subject: <import> enhancement, it's done, but do you like how it works?
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

As you may have seen, the import tag patch now supports redefining 
targets  :-)

Suppose this target:

<target name="mytarget" depends="a,b,c"><dostuff/></target>

is in a file that is imported by my buildfile.

With the patch I can redefine it as follows:

  <target name="mytarget">
    <dostuff1/>
    <antcall target="super.mytarget"/>
    <dostuff2/>
  </target>


Now, mytarget currently does *not* inherit dependencies, although, 
having used the same name, it will effectively replace the old version 
in the graph.

This is the order in which the targets are called, also with the outcome 
in case we enable dependency inheritance:

  1 original mytarget:   a->b->c->dostuff
  2 redefined mytarget:  dostuff1->a->b->c->dostuff->dostuff2
  3 dependency inherit:  a->b->c->dostuff1->dostuff->dostuff2

IMHO (2) would be the outcome that users think comes out.

What do you think?

-- 
Nicola Ken Barozzi                   nicolaken@apache.org
             - verba volant, scripta manent -
    (discussions get forgotten, just code remains)
---------------------------------------------------------------------


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>