ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dominique Devienne <DDevie...@lgc.com>
Subject RE: [VOTE] Ant 1.5 Final Release
Date Mon, 08 Jul 2002 19:51:44 GMT
As Diane pointed out, it deletes lines that become empty after the
substitution. A custom filterreader would have no way to differentiate
previously empty lines from the ones made empty because of the substitution.
A <deletelinesregex pattern=""/> would do it though, I guess. Aside from
allowing to turn around the bug in <replacelineregex/>, it might even be
useful by itself. --DD

-----Original Message-----
From: Magesh Umasankar [mailto:umagesh@apache.org] 
Sent: Monday, July 08, 2002 2:37 PM
To: Ant Developers List
Subject: Re: [VOTE] Ant 1.5 Final Release

----- Original Message ----- 
From: "Diane Holt" <holtdl@yahoo.com>


> > Maybe we need an explicit attribute namely "deleteEmptyLines"...
> 
> That's what I did in my second go 'round, since that's what Stefan asked
> for. Except I called it 'deleteonempty', since it doesn't delete already
> empty lines -- it just deletes lines that become empty on substitution.

-0 to get it into 1.5 for the sole reason 
that it would open the flood gates for other
such similar small enhancement patch requests.
Is this such a blocker as to get it into 1.5?

> 
> > But again if it were a <filterchain>, all one would need to do is
> > add a custom filterreader element like <deleteemptylines/> ;-)
> 
> My little change was trivial -- doing it this way would require someone
> who already knows how all that stuff works (hint,hint :)

In 1.6, by all means...

> Diane

Cheers,
Magesh

***********************************************************
*  Classic: A book which people praise, but do not read.  *
***********************************************************



--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message