ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 10719] - Files processed under SQL task are hacked
Date Thu, 18 Jul 2002 20:17:31 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10719>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10719

Files processed under SQL task are hacked





------- Additional Comments From kdenehy@att.net  2002-07-18 20:17 -------
Thanks Jonathan for going to the trouble of submitting a fix.  It looks like it 
should work, but I didn't test it, because I noticed that both your fix and the 
original code also strip out comments.

I don't want the comments stripped from my Oracle PL/SQL stored procedures, 
triggers, etc., so I made my own modifications to the runStatements method, and 
it seems to work fine.

Since the Java code doesn't have comments explaining all the work that method 
does to strip out SQL comments and formatting, it's hard for me to know whether 
my changes would break the task for databases other than Oracle.  I've run it 
with SQL that creates tables, indexes, packages, package bodies, triggers, 
views, and sequences; drops all of the above; and inserts rows into several of 
the tables, and everything seems to work fine.

Can any of the developers comment (no pun intended :) on whether the comments 
really need to be stripped?

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message